search

cloudfoundry / bosh-softlayer-cpi-release

An external BOSH CPI for the SoftLayer cloud written in Golang
Apache License 2.0
14 stars 20 forks source link

Add PrimarySubnetId to support primary subnet #232

Closed mattcui closed 7 years ago

mattcui commented 7 years ago

#137608987

Signed-off-by: Lance Liu, xliuxu <l.liu, xliuxu@gmail.com>

cfdreddbot commented 7 years ago

Hey mattcui!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

mattcui commented 7 years ago

@maximilien, I think we already addressed your comments, please help review again. Thanks.

/cc @EdwardStudy

zhangtbj commented 7 years ago

Hi @maximilien,

Lance and I add 8 more tests for this method refine, there are three types: 1, Test Id and Subnet Id in network setting: 4 tests 2, Test Id and Subnet Id in cloudProps: 4 tests 3, Test Id and Subnet Id in both network setting and cloudProps: 4 tests

Below is the new unit test table which we added, please review and let us know if you have any suggestion. Thanks a lot! :)

PrimaryNetworkComponent PrimaryBackendNetworkComponent PrivateNetworkOnlyFlag
NETWORK (Id) NETWORK (PSId) NONE
NONE NETWORK (Id, PSId) NETWORK
NETWORK (Id, PSId) NETWORK (Id) NONE
NETWORK (PSId) NONE CLOUDPROPS
CLOUDPROPS (Id) CLOUDPROPS (Id, PSId) NONE
CLOUDPROPS (Id, PSId) NONE CLOUDPROPS
NONE CLOUDPROPS (PSId) NONE
CLOUDPROPS (PSId) CLOUDPROPS (Id) CLOUDPROPS
NE (Id), CL (Id, PSId) NE (Id), CL (Id, PSId) CLOUDPROPS
NE (Id, PSId), CL (Id) NE (Id, PSId), CL (Id) NONE
NE (Id), CL (PSId) NE (PSId), CL (Id) CLOUDPROPS
NE (Id, PSId), CL (Id, PSId) NE (Id, PSId), CL (Id, PSId) NONE
maximilien commented 7 years ago

Thanks for the tests guys. Sorry it took so long to review. Merging :)