search

cloudfoundry / bosh-softlayer-cpi-release

An external BOSH CPI for the SoftLayer cloud written in Golang
Apache License 2.0
14 stars 20 forks source link

Add unit test for other actions #238

Closed edwardstudy closed 7 years ago

edwardstudy commented 7 years ago

With unit test work, some code implemented actions change:

  1. Replace SoftlayerStemcellService struct with Service interface in create_stemcell.go, delete_stemcell.go and delete_vm.go.
  2. Fix error message in create_vm.go.
  3. Regenerate fakes virtual_guest_service with ssh key stuff.
cfdreddbot commented 7 years ago

Hey EdwardStudy!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/146384735

The labels on this github issue will be updated when the story is started.