cloudfoundry / buildpack-packager

Buildpack Packager
Apache License 2.0
23 stars 31 forks source link

Change caching behavior for file:/// paths. #18

Closed vzickner closed 6 years ago

vzickner commented 6 years ago

Ruby changed in on of the recent versions its behavior of URI for files. They introduced URI::File which also allows hostnames for files. This result in a different behavior for the to string method, because it returns with file:///. To avoid this behavior and since there are no credentials for file:, it can be returned directly. See also for reference the new URI::File: https://github.com/ruby/ruby/commit/04883f12c8944922117482d4d446502e5d5d3413

cfdreddbot commented 6 years ago

Hey vzickner!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158546846

The labels on this github issue will be updated when the story is started.

sclevine commented 6 years ago

Thanks for the PR! FYI, this repo is deprecated in favor of libbuildpack: https://github.com/cloudfoundry/libbuildpack/tree/master/packager/buildpack-packager

vzickner commented 6 years ago

Hi @sclevine, I also figured this out. But unfortunately, this repository is still used by for example the https://github.com/cloudfoundry/php-buildpack

vzickner commented 6 years ago

I will reopen this pull request because of the CLA Agreement.