Use -x instead of --exclude to zip command to facilitate old versions

[jghiloni]

My current client works in a controlled environment and due to security controls, it is very difficult to upgrade internal linux tools. Currently, buildpack-packager --cached commands fail on this machine due to the fact that their version of zip is so old (v2.31), it does not support the --exclude parameter. However, it does support -x, which newer versions support as well, with the same basic syntax. This PR switches --exclude to -x to facilitate older versions of zip.

[cfdreddbot]

Hey jghiloni!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/107948062.

[flavorjones]

Wow, the things you find in the real world, huh? This seems reasonable, we'll schedule some time to look at it.

[jghiloni]

Right? The error that it gives too zip error: unrecognized option - is SUPER helpful too :)

[jchesterpivotal]

Maaaaaaan, I remember changing everything to the long-name forms because I hate single-character switches.

boo hiss legacy

[jghiloni]

We could go the route of the Java buildpack and use ruby zip tools and obviate this whole thing... :smile:

[mavenraven]

Hey @jghiloni, when I apply this patch, the intergration tests fail for buildpack-packager. Could you resubmit this with the tests passing please?

[jghiloni]

Updated to change * in -x args to \\*, as the man page for zip calls for. Confirmed all tests (run by executing bundle install && bundle exec rake) are passing. If that's insufficient, please let me know.

[mavenraven]

@jghiloni The change has been added. Good luck!