search

cloudfoundry / capi-ci

Apache License 2.0
8 stars 16 forks source link

Allow the GCP instance type to be customized #5

Closed jenspinney closed 6 years ago

jenspinney commented 6 years ago

If the (optional) GCP_INSTANCE_TYPE param is specified for the create-bosh-lite concourse task, the given instance type will be used when creating bosh lites.

We found that the default instance type from bosh-deployment (n1-standard-8) was overpowered for our needs, so we're using a smaller instance type to save money.

For us, n1-standard-4 is just as performant and is half the price. For more details on our experimentation to reach this conclusion, see this story: https://www.pivotaltracker.com/story/show/156622117

Note: we intentionally made this PR in a way that would not break the CAPI pipeline. A cleaner way to do this might be to add an additional concourse input to be able to provide arbitrary ops files, and then the GCP_INSTANCE_TYPE parameter could be removed. But that wouldn't be possible without requiring a change to the CAPI pool pipeline. If you're interested in this approach, let us know, and we can PR that instead or at a later point.

Thanks, SAPI (@ablease and Jen)

cfdreddbot commented 6 years ago

Hey jenspinney!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.