cloudfoundry / capi-release

Bosh Release for Cloud Controller and friends
Apache License 2.0
24 stars 101 forks source link

Trigger deploying V2 docs #438

Closed pivotalgeorge closed 4 months ago

pivotalgeorge commented 4 months ago

Thanks for contributing to the capi_release. To speed up the process of reviewing your pull request please provide us with:

pivotalgeorge commented 4 months ago

an alternative implementation would be to use repository_dispatch [see here for changes on the target-workflow side.] Both link to this detail in the REST doc.

pivotalgeorge commented 4 months ago

I was about to open an analogous PR - something like #trigger-docs against CCNG since we reversed the desired trigger direction (building GH Pages docs under capi-release with the contents pulled from CCNG) However, upon reflection it seems like this should already be handled by docs changes making it into capi-release as submodule updates and triggering a docs build on every Release

+ @moleske @sethboyles @evanfarrar since y'all were part of the CCNG <-> CAPI Release conversation as far as triggering on version changes goes => Let me know if your understanding is different -- otherwise I will close this PR

moleske commented 4 months ago

I have no strong feelings one way or the other.

I was mostly curious what the plan/goal was. If we don't think we need to trigger on versions cause every docs commit causes a deploy to happen that's good enough for me. I think the repository dispatch implementation would be unnecessarily complicated for what we want

edit - actually what I want is to delete the v2 api, but today will not be that day (joking but not really)