cloudfoundry / capi-release

Bosh Release for Cloud Controller and friends
Apache License 2.0
24 stars 101 forks source link

Audit events should be logged by all components #458

Closed Samze closed 2 months ago

Samze commented 3 months ago

Issue

This commit enabled logging audit events by default in Cloud Controller API, see https://github.com/cloudfoundry/capi-release/commit/ae5be1b9bb052cfaa8a7ef0a41fa9886f3d47042. However, this did not enable it by default in Cloud Controller Worker or Cloud Controller Clock. They have separate properties https://github.com/cloudfoundry/capi-release/blob/develop/jobs/cloud_controller_worker/spec#L111 and these are disabled by default.

The worker often processes user initiated actions, such as Deletion and these create audit events, these are currently not being logged by default. Often its the case that create audit events are logged synchronously, and since delete actions are async, their audit events are not logged.

Possible Fix

We should just use a single cc log_audit_events property and consume it from the worker/clock components.

Samze commented 2 months ago

Closing as fixed in #459