Refactor: credhub service broker asset - Githubissues

cloudfoundry / cf-acceptance-tests

CF Acceptance tests

Apache License 2.0

69 stars 170 forks source link

Refactor: credhub service broker asset #1099

Closed ctlong closed 3 months ago

ctlong commented 3 months ago

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Refactors assets/credhub-service-broker to use a config struct rather than have various os.GetEnv calls & global vars scattered around.

Please provide contextual information.

None.

What version of cf-deployment have you run this cf-acceptance-test change against?

None.

Please check all that apply for this PR:

[ ] introduces a new test --- Are you sure everyone should be running this test?
[ ] changes an existing test
[ ] requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

[ ] YES
[x] N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None.

What is the level of urgency for publishing this change?

[ ] Urgent - unblocks current or future work
[x] Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None.