Correctly print CF CLI version - Githubissues

cloudfoundry / cf-acceptance-tests

CF Acceptance tests

Apache License 2.0

69 stars 170 forks source link

Correctly print CF CLI version #1106

Closed johha closed 3 months ago

johha commented 3 months ago

What is this change about?

STDOUT output of fmt is not captured by ginkgo and thus the version is not printed. When using GinkgoWriter the message is captured correctly.

Please check all that apply for this PR:

[ ] introduces a new test --- Are you sure everyone should be running this test?
[ ] changes an existing test
[ ] requires an update to a CATs integration-config -> not applicable

Did you update the README as appropriate for this change?

[ ] YES
[x] N/A

What is the level of urgency for publishing this change?

[ ] Urgent - unblocks current or future work
[x] Slightly Less than Urgent

ctlong commented 3 months ago

@johha do we still need the PauseOutputInterception() and ResumeOutputInterception() calls around it now?

johha commented 3 months ago

@johha do we still need the PauseOutputInterception() and ResumeOutputInterception() calls around it now?

Still need it to show the version number