Fixes an inconsistency in the credhub, docker, and route_services test suites (vs other suites) where apps were not get deleted after tests. Specifically, some service brokers that were pushed as apps were not getting deleted, only unregistered as service brokers.
I ran through some of the steps manually and saw that the delete-service-broker command did not also delete the service broker app.
Please provide contextual information.
Spot-checking the credhub suite, I couldn't find any reasons in git or tracker stories for the delete command to not to be originally included. Possibly, it was believed that the delete-service-broker command would delete the app...
What version of cf-deployment have you run this cf-acceptance-test change against?
v33.4.0
Please check all that apply for this PR:
[ ] introduces a new test --- Are you sure everyone should be running this test?
[ ] changes an existing test
[ ] requires an update to a CATs integration-config
Did you update the README as appropriate for this change?
[ ] YES
[x] N/A
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
About the same.
What is the level of urgency for publishing this change?
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Fixes an inconsistency in the credhub, docker, and route_services test suites (vs other suites) where apps were not get deleted after tests. Specifically, some service brokers that were pushed as apps were not getting deleted, only unregistered as service brokers.
I ran through some of the steps manually and saw that the delete-service-broker command did not also delete the service broker app.
Please provide contextual information.
Spot-checking the credhub suite, I couldn't find any reasons in git or tracker stories for the delete command to not to be originally included. Possibly, it was believed that the delete-service-broker command would delete the app...
What version of cf-deployment have you run this cf-acceptance-test change against?
v33.4.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
About the same.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None