search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Update version of bbl to 2.4.1 #10

Closed DaxterM closed 7 years ago

cfdreddbot commented 7 years ago

Hey DaxterM!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/141349893

The labels on this github issue will be updated when the story is started.

dsabeti commented 7 years ago

Hey @DaxterM. Thanks for this PR, but we're actually locked to 2.1.1 because newer versions introduce a bug with TCP load balancing -- briefly, bbl has the TCP load balancers perform their health check against port 80 (instead of the original 8080), but it doesn't update the firewall rules to allow traffic to that port, so health checks will always fail. Once this commit makes it into a new version of bbl, we can bump.

/cc @evanfarrar

DaxterM commented 7 years ago

Ah, ok. I was looking for the newer version so I could take advantage of bbl print-env for a task I'm working on. I'll just create a new image, thanks!