cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

Make vars-files input optional on bosh-deploy task #100

Closed cfryanr closed 4 years ago

cfryanr commented 4 years ago

What is this change about?

Looks like the task script is happy for this directory to be empty, yet the task will fail if it is not provided as an input. This is not so convenient for users who do not have any vars files to provide. Thus, make it an optional input.

Please provide contextual information.

https://cloudfoundry.slack.com/archives/C0FAEKGUQ/p1572475327009500

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

vars-files input is now optional on bosh-deploy task

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

@tylerschultz

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/169470333

The labels on this github issue will be updated when the story is started.

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.

weymanf commented 4 years ago

@cfryanr Could you please take a look at the CLA error?

cfryanr commented 4 years ago

@weymanf I'm not able to fix the CLA error and I've reached out to the admins for help.

cfryanr commented 4 years ago

@weymanf I was able to fix the CLA issue with some help from the admins.