cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

Can use toolsmiths-env metadata #101

Closed rowanjacobs closed 4 years ago

rowanjacobs commented 4 years ago

What is this change about?

This PR adds a new toolsmiths-env input to many of the tasks relying on bbl state (specifically, to tasks which do not run bbl commands other than print-env and which are not involved with cleaning up an environment. The bbl-state input is now optional, although the tasks will error if neither input is provided. When the toolsmiths-env input is provided, the new --file flag will be provided to bbl print-env, which will read desired environment variables from the Toolsmiths environments app metadata file.

This is necessary for users of Toolsmiths cf-deployment environments to be able to use cf-deployment-concourse-tasks, since the Toolsmiths environments app does not provide users with a full bbl state.

Please provide contextual information.

This depends on this PR being merged.

Related Tracker stories:

Related Slack thread (unfortunately most of the actual discussion of this was done over video and unrecorded)

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Allow users to specify Toolsmiths' metadata instead of bbl state when targeting environments.

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

cc @nhsieh @cloudfoundry/pcf-toolsmiths

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/169854870

The labels on this github issue will be updated when the story is started.

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.