search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Fixes metadata capability for toolsmiths-env #102

Closed bbtong closed 4 years ago

bbtong commented 4 years ago

What is this change about?

Fixes the metadata code for toolsmiths-env added in a previous PR.

Please provide contextual information.

Include any links to other PRs, stories, slack discussions, etc... that will help establish context. The issue is that some functions were still looking at the bbl-state and not toolsmiths-env, so this PR adds code to resolve this issue raised by: this Slack interrupt which opened this story

To fix: this PR

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Fixes bug in allowing users to specify Toolsmiths' metadata instead of bbl state when targeting environments.

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

cc @nhsieh @bbtong @cloudfoundry/pcf-toolsmiths

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/169988226

The labels on this github issue will be updated when the story is started.

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.

bbtong commented 4 years ago

@davewalter We've pushed the fixes for the above reviewed issues. Thank you for catching those!

davewalter commented 4 years ago

Looks good, thanks! Merging...

davewalter commented 4 years ago

@bbtong @rowanjacobs Are you able to verify this change in your CI before we cut a new version? We aren't currently set up with an "internal" Concourse worker to allow us to interact with the cf-d pools in CI yet.

rowanjacobs commented 4 years ago

We have one more change we need to make before it's ready, @davewalter. Do you want us to create a new PR?

davewalter commented 4 years ago

We have one more change we need to make before it's ready, @davewalter. Do you want us to create a new PR?

Yes, please @rowanjacobs. Unfortunately, I went ahead and merged this last night.

rowanjacobs commented 4 years ago

No problem. We just submitted #103