cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

feature: set SYSTEM_DOMAIN variable for toolsmiths #104

Closed KauzClay closed 4 years ago

KauzClay commented 4 years ago

Co-authored-by: Bruce Ricard bricard@pivotal.io

What is this change about?

When using a toolsmiths environment, the SYSTEM_DOMAIN is dynamically fetched from the metadata. It cannot be passed as a parameter in the pipeline configuration.

Please provide contextual information.

https://www.pivotaltracker.com/story/show/169068487

Please check all that apply for this PR:

The error message is slightly different now. Not sure if that counts as a breaking change.

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Tasks can be used with toolsmiths Cf-Deployment environments

What is the level of urgency for publishing this change?

We are technically blocked, but are using our fork in the meantime.

Tag your pair, your PM, and/or team!

@bruce-ricard

networking in slack

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/170392152

The labels on this github issue will be updated when the story is started.