search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

Added vSphere support #109

Closed axelaris closed 4 years ago

axelaris commented 4 years ago

What is this change about?

Added support for vSphere backend

Please provide contextual information.

n/a

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Added support for vSphere backend

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172326325

The labels on this github issue will be updated when the story is started.

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.

Birdrock commented 4 years ago

@axelaris Hi Alexey - thanks for the PR!

Could you give us an idea of what level of testing you have done for this? We don't currently have infrastructure for testing this PR, so we are interested in what you have done to ensure operation.

axelaris commented 4 years ago

Hi @Birdrock, thank you for looking into my PR. Currently I'm actively using my fork to deploy CF to our internal vSphere infra. Do you need any details/logs to prove that?

jamespollard8 commented 4 years ago

Thanks @axelaris. After some team discussion we've decided that we're comfortable with merging this without validating it in our own pipelines. Especially after hearing that you've tested it yourself.