cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

bosh-deploy-with-created-release task should default to `name` if `final_name` is unavailable #111

Closed MasslessParticle closed 4 years ago

MasslessParticle commented 4 years ago

It doesn't look like releases can be named with final_name or name (but not both) in bosh release. See these two commits on the bosh-cli:

It would be great if this task could support either convention in bosh releases:

Relevant code https://github.com/cloudfoundry/cf-deployment-concourse-tasks/blob/b9c1ad424516df9efa84e5fa4353f80facfd4a13/bosh-deploy-with-created-release/task#L38

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/173784667

The labels on this github issue will be updated when the story is started.

davewalter commented 4 years ago

Hi @MasslessParticle,

Thanks for reporting this. We're surprised that it has taken 4 years for someone to run into this issue! We've implemented a fix here. Could you please try it out and let us know if it works for you?

Thanks, Dave and @ericpromislow

mdelillo commented 4 years ago

@davewalter @ericpromislow This change requires yq which isn't in the dockerfile

davewalter commented 4 years ago

Thanks for catching this @mdelillo. I think this has been added so you should be good to go.

jamespollard8 commented 4 years ago

Closing as fixed by 9e45d4c (with a little help from https://github.com/cloudfoundry/cf-deployment-concourse-tasks/pull/114/files)