cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Move pipefail option in bbl-up/task script #117

Closed belinda-liu closed 3 years ago

belinda-liu commented 3 years ago

What is this change about?

A previous PR introduced the pipefail option to the bbl-up task. However, the formatting of that change does not work on linux machines, since linux interprets anything after the shebang as one argument (see https://unix.stackexchange.com/questions/533415/invalid-option-name-error-with-shebang-bin-bash-o-pipefail-in-script). This is a simple change to pull the pipefail option into a newline so it gets parsed correctly.

Please provide contextual information.

Previous PR: https://github.com/cloudfoundry/cf-deployment-concourse-tasks/pull/116

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

What is the level of urgency for publishing this change?

*but worth calling out that this had broken our pipeline, and may have done the same for others.

Tag your pair, your PM, and/or team!

@sweinstein22

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176273336

The labels on this github issue will be updated when the story is started.