cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

Update run-cats to use the new Ginkgo v2 CLI flags #129

Closed davewalter closed 1 year ago

davewalter commented 1 year ago

What is this change about?

This PR updates the flags specified in the run-cats task to use the new versions of the Ginkgo v2 CLI and updates the slow spec threshold to be a Golang time duration instead of a number of seconds. A new TIMEOUT parameter has been introduced to allow CI jobs to change the default Ginkgo timeout, which is now applied to the entire test suite run, instead of each individual test suite. It defaults to 2 hours, instead of the Ginkgo default of 1 hour.

Please provide contextual information.

Related to https://github.com/cloudfoundry/cf-acceptance-tests/pull/543

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

The Ginkgo CLI flags specified in the run-cats task have been updated to use the new versions of v2. The slow spec threshold has been updated to be a Golang time duration instead of a number of seconds. A new TIMEOUT parameter has been introduced to allow CI jobs to change the default Ginkgo timeout, which is now applied to the entire test suite run, instead of each individual test suite. It defaults to 2 hours, instead of the Ginkgo default of 1 hour.

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

@ctlong

davewalter commented 1 year ago

I forgot to mention on this PR that we should wait to merge this until we have cut a new release of CATs with the Ginkgo v2 changes.