search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Discussion: Thoughts on converting some of these task files to resources #13

Closed ljfranklin closed 4 years ago

ljfranklin commented 7 years ago

Hi all,

Has been any discussion around converting some of these tasks to a first-class Concourse resource? While the tasks work, the interface seems not as convenient or flexible as it could be due to the limitations on Concourse tasks. For example, this issue is caused by tasks having to explicitly declare a set number of inputs while a resource put can have an arbitrary number of inputs. We also have to duplicate params for each task (e.g. VARS_STORE_FILE) where a resource could have a single source.vars_store field.

Specifically I would really like to see a bbl-resource and some of the deploy tasks can already be replaced with the bosh-deployment-resource.

And thanks for sharing these tasks! CAPI team uses them heavily in CI.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/142429197

The labels on this github issue will be updated when the story is started.

dsabeti commented 7 years ago

@ljfranklin, I think it makes a ton of sense to try to convert these into resources -- after all, resources are meant to capture stateful things, and bbl up and bosh deploy definitely affect state. The reason these are tasks are mostly because we originally made the tasks for ourselves (CF Release Integration) to use for our own CI, and then we just polished them for more general use. Were we to start from scratch, we'd likely have built them as resource.

It's probably worth it for us to consider turning them into resources, but we don't have a ton of bandwidth. I'll update this issue if we get a chance to do so.

dsabeti commented 7 years ago

/cc @anEXPer

davewalter commented 4 years ago

Closing due to inactivity. Please feel free to re-open if desired.