cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

improve output for bbl up/destroy tasks #133

Closed will-gant closed 1 year ago

will-gant commented 1 year ago

What is this change about?

Fixes a small issue in the bbl-up task which causes it to fail to print the nameservers for the created DNS zone when deploying on AWS.

Please provide contextual information.

For some odd reason, bbl gives this output different names for aws and gcp. For the latter it's named system_domain_dns_servers, and for the former it's env_dns_zone_name_servers. As a result, this is the build output you currently get if you're running on aws (and presumably any other IaaS other than gcp):

Please configure DNS with the following servers:
+ bbl outputs
+ yq .system_domain_dns_servers -y
+ cut '-d ' -f2
null

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Bug fix

What is the level of urgency for publishing this change?