search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

FEATURE: bosh-cleanup task optionally uses --all #14

Closed angelachin closed 7 years ago

angelachin commented 7 years ago

The bosh-cleanup task currently uses --all flag. We would like it if the --all flag was optional.

Our use case is a couple jobs in our pipeline that deploy two different deployments (it tests upgrading from one to the other). It would be nice if we could run bosh cleanup without the --all option so that the releases for the not-currently-deployed deployment would not get deleted.

Thanks, Angela & @mcwumbly

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/144659045

The labels on this github issue will be updated when the story is started.

dsabeti commented 7 years ago

Hey @chinangela, this sounds reasonable. Have you verified that removing --all keeps the correct release versions on your BOSH director?

angelachin commented 7 years ago

@dsabeti yes, just verified that removing --all keeps the versions we want. In general, it seems to keep the latest 3 releases.

dsabeti commented 7 years ago

Sounds good. I'll prioritize the story.

dsabeti commented 7 years ago

@chinangela, take a look at the task now. It supports use of a CLEAN_ALL parameter that you can set to false.

angelachin commented 7 years ago

Awesome, thanks a lot!