cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

Update bosh-deploy-with-created-release to build a valid manifest when specifying a release tarball #159

Closed geofffranks closed 11 months ago

geofffranks commented 11 months ago

Update bosh_interpolate to pull release version info from the provided tarball to avoid bosh manifest errors

What is this change about?

When providing a release tarball to bosh-deploy-with-created-release, the resultant manifest doesn't include a version directive for the release, and bosh fails to validate the manifest.

Please provide contextual information.

If you're able to see it, this breaks the windows-roofts pipeline, and we're trying to consolidate onto common tasks instead of previously used release-specific tasks that didn't suffer from this issue.

This is a much smaller fix in scope than #139, but if that is deemed preferable, this one is likely not needed.

Please check all that apply for this PR:

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Fixes an issue with bosh-deploy-with-created-release where passing a release_tarball_name would result in an invalid BOSH manifest, and deployments would fail.

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.