search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 75 forks source link

CF-CLI input in CATS task is not used correctly #189

Open johha opened 2 months ago

johha commented 2 months ago

The CATS tasks allows to provide a cf-cli input. However in the task itself it expects that CF CLI is provided as binary which the CF CLI Github release does not provide. Additionally it's unclear if the PATH is set correctly so that CATS would use the provided CF-CLI.

ctlong commented 2 months ago

Hi @johha,

❓ Out of curiosity, what is causing you to want to provide the run-cats task with a cf CLI input?

the task itself it expects that CF CLI is provided as binary which the CF CLI Github release does not provide.

True, it would be more convenient for the task to extract a binary from a provided cf CLI GH release. I imagine it may not have been added because that creates more potential tech debt for the task itself 🤷

✍️ If you want to PR this change, I would accept it.

In the meantime, you could write an in-between task in your concourse pipeline to extract the appropriate binary and provide it to the run-cats task.

it's unclear if the PATH is set correctly so that CATS would use the provided CF-CLI.

What makes you say that? It seems like a cf binary in the cf-cli input path, if provided, would be set at the front of the PATH.

johha commented 2 months ago

Hi @ctlong 👋

last week when we had this regex issue in CATS (https://github.com/cloudfoundry/cf-acceptance-tests/pull/1105) we wanted to downgrade the CF CLI version, however as described above this didn't work. @philippthun and me tried to fix it by adjusting the task to download the CLI (https://github.com/cloudfoundry/cf-deployment-concourse-tasks/commit/db9978c3fdba0da4604e6e7bbf2b1fc0b61f8e67). However CATS still was using the newer CLI version (part of the image) 🤷‍♂️ I'd say it's not a urgent issue but something we would look into eventually. If you want I can assign it to myself.