search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Setting the committer name and email #19

Closed utricularian closed 3 years ago

utricularian commented 7 years ago

We want to use the tasks in this repo, but we'd also like to set the commits with our own teams email address and bot username. Are there any plans to parameterize git config such as: https://github.com/cloudfoundry/cf-deployment-concourse-tasks/blob/7c86b2a790c68d326be3592969f240d207e58342/shared-functions#L26

cc @zankich

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/147541559

The labels on this github issue will be updated when the story is started.

dsabeti commented 7 years ago

@utricularian That seems like a very reasonable feature request. I'm going to co-opt this issue and the corresponding tracker story to allow that to be parameterized.

I think the update to the interface would be:

...
params:
  BBL_STATE_DIR:
  MANIFEST_FILE: cf-deployment.yml
  OPS_FILES:
  SYSTEM_DOMAIN:
  VARS_STORE_FILE: deployment-vars.yml
  REGENERATE_VARS_STORE: false

  # New param
  GIT_COMMIT_EMAIL: cf-release-integration@pivotal.io

It maintains backwards compatibility and gives a default, but pretty easily allows the user to override it.

dsabeti commented 7 years ago

Hey @utricularian, take a look at the latest release: https://github.com/cloudfoundry/cf-deployment-concourse-tasks/releases/tag/v3.7

davewalter commented 3 years ago

This was implemented back in 2017.