search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Remove bosh-init from Dockerfile #22

Closed dpb587-pivotal closed 7 years ago

dpb587-pivotal commented 7 years ago

Not sure if it's retained for a reason, but it doesn't seem like it's used (and it's also an older version with some buggy behavior). Dunno; PR if useful.

cfdreddbot commented 7 years ago

Hey dpb587-pivotal!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/149202989

The labels on this github issue will be updated when the story is started.

dpb587-pivotal commented 7 years ago

Also, nice job versioning docker images, providing these tasks as a sort of API, and documenting them!

dsabeti commented 7 years ago

@dpb587-pivotal, I think we needed it in the past, when bbl used it instead of bosh-deployment. @anEXPer @evanfarrar, do you think we still need bosh-init in these docker images?

anEXPer commented 7 years ago

No. Let's cut it.

anEXPer commented 7 years ago

We got to this in the backlog, so I'm merging it.

I'll note that since bbl is implicitly part of our contract, and the version of bbl in the image hasn't used this code for some time, removing it should probably be a patch version.

Also, @dpb587-pivotal, thanks for appreciating our semantic versioning/implicit contract work on these! We're trying to make working with CF in CI a pleasing and reasonable experience. If you've got any other feedback on accomplishing that, Issues here or on cf-d itself are always welcome.