cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Use shared-functions for all setup_bosh_env_vars calls #27

Closed rowanjacobs closed 7 years ago

rowanjacobs commented 7 years ago

This accomplishes essentially the same function as PR #26 but goes about it slightly differently. In this case, the setup_bosh_env_vars function from shared-functions is used in place of every inline setup_bosh_env_vars function definition. Some other functions have been renamed to avoid name collisions.

This is needed to implement support for jumpboxes in the BBL pipeline since eval "$(bbl print-env)" now also starts up the ssh tunnel to connect to the BOSH director through the jumpbox.

The relevant Tracker story is here: https://www.pivotaltracker.com/story/show/146740257

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/150190683

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 7 years ago

Hey rowanjacobs!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cfdreddbot commented 7 years ago

Hey rowanjacobs!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/150190751

The labels on this github issue will be updated when the story is started.