search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Allow dynamic list of feature flags to be enabled/disabled #32

Closed Samze closed 6 years ago

Samze commented 6 years ago

The current set-feature-flag task only allows diego_docker + task_creation to be set. We would like to be able to enable/disable any feature flags.

This PR is an alternative design, its more a conversation starter. Thoughts?

Note: Totally not backward compatible or anything sensible like that.

cfdreddbot commented 6 years ago

Hey Samze!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151557595

The labels on this github issue will be updated when the story is started.

dsabeti commented 6 years ago

Hey @Samze. I really like the idea behind this change. It's definitely backwards-incompatible, but that's what major version bumps are for! It's been a minute since the last major version bump, so I'm amenable to doing one soon. Let me see if I can find any other good backwards-incompatible changes that we should include for cf-deployment-concourse-tasks 5.0

rowanjacobs commented 6 years ago

Since bbl 5.0 has recently been released, which requires a jumpbox on all IAASes, perhaps a suitable change would be requiring an open SSH tunnel for all tasks which dial the BOSH director.

dsabeti commented 6 years ago

@rowanjacobs, bbl 5.0 seems like a good change to fold in as well. Since we're already using bbl print-env, this should automatically establish the ssh connection, right? My understanding is that by upgrading to bbl 5.0, the real breaking change in the interface of this repo will be that we will require users to provide their bbl/IAAS creds to each task.

cc @evanfarrar