search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Track the entire contents of the bbl state dir #38

Closed rowanjacobs closed 6 years ago

rowanjacobs commented 6 years ago

bbl now writes multiple files to the state directory, including terraform templates and state, vars-store files, create and delete env scripts, and manifests and ops files for the director and jumpbox. Since some of these files hold state which was formerly present in bbl-state.json, they should be tracked by Git as part of the user's bbl states repo.

cc: @desmondrawls @evanfarrar

cfdreddbot commented 6 years ago

Hey rowanjacobs!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cfdreddbot commented 6 years ago

Hey rowanjacobs!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152160757

The labels on this github issue will be updated when the story is started.

dsabeti commented 6 years ago

Cool, thanks for this PR @rowanjacobs. Which version of bbl does this depend on? We're currently pinned to 4.10.4, so we'll get around to merging this once we upgrade up into bbl 5.

evanfarrar commented 6 years ago

It doesn't depend on any particular version of bbl, this is forwards compatibility for a refactoring of the state directory in bbl 5.2.0. You can delay merging it, but you will break on a certain version of bbl 5

dsabeti commented 6 years ago

Yeah, I see that my question was imprecise. I guess I was really asking, "For which version of bbl is this change necessary?"

evanfarrar commented 6 years ago

yeah, 5.2.0 (currently only a drafted reslease)