search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Add ability to deploy a concourse-deployment manifest #40

Closed mcwumbly closed 5 years ago

mcwumbly commented 6 years ago

These changes allow cf-deployment-concourse-tasks to deploy another manifest like this one: https://github.com/evanfarrar/concourse-deployment

Main changes:

cfdreddbot commented 6 years ago

Hey mcwumbly!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152423642

The labels on this github issue will be updated when the story is started.

rainmaker commented 6 years ago

If this is merged, could the documentation in task.yml and the validation in task be updated to reflect that BBL_LB_CERT and BBL_LB_KEY are optional on GCP with concourse?

dsabeti commented 6 years ago

Sorry to let this PR fester. After lots of other discussion about this, the infrastructure team is working on a Concourse resource for bbl that should help with most what's implemented here.

The one outstanding item this PR introduces is the uploading of a stemcell from a given manifest. I think this could be an interesting task to generalize, although I also think it would be interesting to incorporate it into the bosh-deployment-resource somehow.

heyjcollins commented 5 years ago

@mcwumbly , @rainmaker

It's been several months since this PR was submitted. I'm curious if this is still relevant or whether the Concourse resource and bosh-deployment-resource are sufficient for your needs?

Lastly, as the name implies, cf-deployment-concourse-tasks are meant to be focused on cf-deployment. I have a concern about overloading cfdct as-is and there's also a support burden by broadening the use cases it covers.

But please share your opinions/concerns/needs here when you have a chance so I can consider them when finalizing my decision to merge/not-merge.

Thanks!

mcwumbly commented 5 years ago

I don't have any horse in this race at this time.

When I was working on @cloudfoundry/cf-infrastructure this would have been nice, but perhaps they have a solution now they are happy with? Tagging them in to see what they say...

evanfarrar commented 5 years ago

You can close this, we no longer intend to maintain this integration / support for Concourse.