search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Support Azure #61

Closed norshtein closed 6 years ago

norshtein commented 6 years ago

Hi, changes were made to support Azure, now Azure users can use this repo to set up pipeline.

cfdreddbot commented 6 years ago

Hey norshtein!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156644453

The labels on this github issue will be updated when the story is started.

norshtein commented 6 years ago

Supplementary explanation: I found that IaaS relative information only appears in bbl-up,bbl-destory and bosh-upload-stemcell-from-cf-deployment. In bbl-up and bbl-destory, I added Azure credentials field so that bbl can find it in bash environment to work on Azure; in bosh-upload-stemcell-from-cf-deployment, I added statements to upload Azure stemcell. Also, I add statements in shared-functions to judge that we have IaaS credentials for Azure.

dsabeti commented 6 years ago

This change looks good overall. Thanks for the contribution, @norshtein! I've prioritized the story to get merged.