search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

bosh-deploy task should take in a deployment name as an optional param #67

Closed wfernandes closed 5 years ago

wfernandes commented 6 years ago

Currently the bosh-deploy task gets the deployment_name by interpolating it from the manifest.

So for deployments such as kubo-deployment, we are unable to deploy multiple CFCR clusters using the same director.

It would be super helpful if we could override the manifest's deployment_name with a DEPLOYMENT_NAME param, just like the run-errand task.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/159110325

The labels on this github issue will be updated when the story is started.

wfernandes commented 6 years ago

I guess we could use an ops-file to update the name of the deployment. But I still think the param would be simpler.

ishustava commented 6 years ago

Hey @wfernandes,

We treat manifest as a single source of truth. bosh-deploy task gets deployment name from the (interpolated) manifest: https://github.com/cloudfoundry/cf-deployment-concourse-tasks/blob/4622e63e18db6be8713710a8f1b8761407723a85/shared-functions#L224 So if you add an ops file to rename deployment, this task should work for you.

For example, in cf-deployment we provide an ops file to rename your deployment.

heyjcollins commented 6 years ago

@wfernandes and @ishustava - in cf-deployment 3.0 (to be published any day), the rename-deployment.yml has been merged with the rename-netork.yml. The new ops file is rename-network-and-deployment.yml - this is just a heads up that the file referenced in Iryna's comment will be deleted in the next release.

heyjcollins commented 6 years ago

The intention of the ops file(s) referenced here is to support your use case. If you agree, please close this issue when you have a moment. Else - we'll look for further comment.

Thanks for your feedback,

Josh

heyjcollins commented 5 years ago

Since there's been no response on this issue since July I'm going to close it. If you'd like to see it re-opened, please comment on the issue and reopen.