search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Support --skip-drain in bosh-delete-deployment #68

Closed jasonkeene closed 5 years ago

jasonkeene commented 6 years ago

It would be nice, in situations where you don't care about draining, to be able to supply a SKIP_DRAIN flag to the bosh-delete-deployment task.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/159269884

The labels on this github issue will be updated when the story is started.

jasonkeene commented 6 years ago

I just realized delete-deployment is currently not a flag on the v2 bosh cli. I filed an issue for this in the CLI repo: https://github.com/cloudfoundry/bosh-cli/issues/456

jasonkeene commented 6 years ago

Since there is no --skip-drain on delete-deployment exposing --force would do the trick.

heyjcollins commented 6 years ago

I think this is a great idea for ephemeral environments in CI. We'll expose the force flag. Turning this issue into a feature story and moving it into our backlog.

Thanks for the feedback!

rosenhouse commented 5 years ago

Is this done? @heyjcollins

heyjcollins commented 5 years ago

Hey @rosenhouse - Apologies I went dark on responding here. If you set IGNORE_ERRORS = true, the task will execute the bosh delete-deployment command with the --force flag included. I believe this achieves the goal.

I'm going to close this out with my comment, but if there's more to this issue resolution please comment and reopen.