search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

set use_single_app_instance config through env var #70

Closed nimakaviani closed 5 years ago

nimakaviani commented 6 years ago

Signed-off-by: Nima Kaviani nkavian@us.ibm.com

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/159379430

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 6 years ago

Hey nimakaviani!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

sjolicoeur commented 6 years ago

Please do not merge immediately, we just wanted to expose what we were doing, we still need to figure out how to solve for credhub

heyjcollins commented 6 years ago

@sjolicoeur - since you want us to hold on integrating this, do you have tracker story that we can block this on?

sjolicoeur commented 6 years ago

@heyjcollins here's the link to our story: https://www.pivotaltracker.com/story/show/159444743

sjolicoeur commented 6 years ago

And we are good to proceed with the PR

nimakaviani commented 5 years ago

closing in favor of the upcoming PRs.