search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Update config task to use credhub_admin_client_secret #72

Closed athornton2012 closed 5 years ago

athornton2012 commented 5 years ago

We created a PR in cf-deployment(https://github.com/cloudfoundry/cf-deployment/pull/580) and cf-acceptance tests(https://github.com/cloudfoundry/cf-acceptance-tests/pull/321) to add a UAA credhub_admin_client that has the proper credhub permissions for creating and reading credentials in cf-acceptance tests. This just updates the config to use the credhub_admin_client instead of the cc_service_key_client.

Signed-off-by: Anna Thornton athornton@pivotal.io

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/159662903

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 5 years ago

Hey athornton2012!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please have everyone sign the appropriate CLA (individual or corporate), and send to: contributors@cloudfoundry.org.

When sending a signed CLA please provide your github username in case of an individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

The following github user @chhhavi has not signed the appropriate CLA.

If you are confident that everyone listed is covered under a Corporate CLA, please make sure everyone has publicized their membership in the appropriate Github Org, per these instructions.

Once everyone has publicized their membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

chhhavi commented 5 years ago

Any update on this?