search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Extract `git status` to a variable #81

Closed kirederik closed 5 years ago

kirederik commented 5 years ago

In special circumstances, such as when using git-crypt and running this task on an older version of concourse, git status can fail.

Even though we have -e, when we wrap commands in if statements like this, the expression is evaluated but no checking will be made on the exit code.

Extracting the output of git status to a variable will ensure we are testing not only the output but also exiting when it fails.

cfdreddbot commented 5 years ago

Hey kirederik!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161342425

The labels on this github issue will be updated when the story is started.