search

cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Delete Deployment / Destroy Director flag for no fail #83

Closed zachgersh closed 5 years ago

zachgersh commented 5 years ago

Would y'all be open to a PR that allowed the user to specify a "no-fail" type of scenario? We sometimes have situations where deletes have already been triggered and they end up getting triggered again (thus resulting in a pipeline failure).

I'd love to make it so we do a quick check of if the bbl-state exists and if it does not (and no fail is set) we skip the destroy / delete but return success.

Does this sound ok?

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161828692

The labels on this github issue will be updated when the story is started.

heyjcollins commented 5 years ago

This slack thread includes our discussion about this feature enhancement

heyjcollins commented 5 years ago

As per the thread. we're happy to accept a PR for this so i'm going to go ahead and close this and we'll pull in the PR once y'all have submitted it.

thanks!