cloudfoundry / cf-deployment-concourse-tasks

Apache License 2.0
23 stars 76 forks source link

Delete Terraform plugins before pushing bbl state #98

Closed rowanjacobs closed 5 years ago

rowanjacobs commented 5 years ago

What is this change about?

This change deletes Terraform plugins from the bbl state directory in the bbl-up task before pushing the state to GitHub or tarring and uploading it to S3/GCS/etc.

These plugin files are very large (the GCP one is around 50 MB), and bbl will re-download them as needed using terraform init before every operation, so it's not necessary to keep them on disk.

There was some discussion between us over whether this new behavior should be default or not. We introduced a new parameter, DELETE_TERRAFORM_PLUGINS, to the bbl-up task to control this new behavior. This is currently defaulting to true but we are open to changing it to default false as well.

Please provide contextual information.

This PR came out of an in-person discussion with @vitreuz and @acosta11.

Please check all that apply for this PR:

(my pair thinks this is a breaking change but I don't)

Did you update the README as appropriate for this change?

How should this change be described in release notes?

Delete Terraform plugins from the bbl-state repo before pushing it to Git or uploading it. This new behavior can be disabled.

What is the level of urgency for publishing this change?

Tag your pair, your PM, and/or team!

cc @bruce-ricard cc @cloudfoundry/pcf-toolsmiths

cfdreddbot commented 5 years ago

:white_check_mark: Hey rowanjacobs! The commit authors and yourself have already signed the CLA.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/168306507

The labels on this github issue will be updated when the story is started.

davewalter commented 5 years ago

Thanks @rowanjacobs