search

cloudfoundry / cf-drain-cli

CF CLI plugin to create syslog drains
Apache License 2.0
16 stars 7 forks source link

the help syntax for create-drain is incorrect #6

Closed randomtask1155 closed 6 years ago

randomtask1155 commented 6 years ago 
python-hello-world-flask:> cf create-drain -type metrics "hello-world-flask" my-drain syslog-tls://my-server:1234
Invalid arguments, expected 2, got 3.

https://github.com/cloudfoundry/cf-drain-cli/blob/9475eb14537d21075e993b01e2072a003308175b/main.go#L72

does not allow you to specify <drain-name>

 create-drain [options] <app-name> <drain-name> <syslog-drain-url>

also create-drain is selected from arg 1 even though we define a flag for it. 

https://github.com/cloudfoundry/cf-drain-cli/blob/9475eb14537d21075e993b01e2072a003308175b/internal/command/create_drain.go#L34
cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156730457

The labels on this github issue will be updated when the story is started.

bradylove commented 6 years ago

@randomtask1155 thank you for pointing this out. We had removed the requirement to provide a drain name and forgot to update the help text. This has been fixed.