search

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes
Apache License 2.0
300 stars 115 forks source link

fix secret_name for cf_api_backup_metadata_generator client #559

Closed tcdowney closed 3 years ago

tcdowney commented 3 years ago

WHAT is this change about?

This is a followup PR for a mistake made in https://github.com/cloudfoundry/cf-for-k8s/pull/555.

It includes a pending change to the cf-api-controllers deployment so that this is adequately tested by CI It is OK if that change is reverted since it will come through via a vendir sync in the future and works fine without it for now.

That can either be done through CI naturally as it bumps to the latest capi-k8s-release or manually while merging this.

Does this PR introduce a change to config/values.yml?

No

Acceptance Steps

Same as https://github.com/cloudfoundry/cf-for-k8s/pull/555. You should be able to do something like this and see it work after the deploy has succeeded:

kubectl exec -n cf-system cf-api-controllers-6cb4d79d5c-z6ntn -c backup-metadata-generator -- "/cnb/process/generate-metadata"

CAKE Story: #175469923

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/175567736

The labels on this github issue will be updated when the story is started.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

tcdowney commented 3 years ago

@davewalter I actually was waiting to make the capi-k8s-release change until after this was merged since the deploy doesn't succeed without this cf-for-k8s change. I only included that on the PR cause I hoped it would run through the integration tests and see everything pass. The plan was to remove the config/capi/_ytt_lib/capi-k8s-release/templates/controllers_deployment.yml change after that happened.

tcdowney commented 3 years ago

I just went ahead and removed it. I tested the deploy locally and it was fine.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

davewalter commented 3 years ago

Sorry about that @tcdowney. Our CI is very protective of the component templates we include in cf-for-k8s. We'll get this merged in once the rest of the tests pass.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

tcdowney commented 3 years ago

Seems like there is an issue with the external-blobstore tests:

Error attaching, falling back to logs: unable to upgrade connection: container minio-client-25f48941698aec50d057e28b not found in pod minio-client-25f48941698aec50d057e28b_default

I don't see any reason this would be related, though. 🤔

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

tcdowney commented 3 years ago

@davewalter do those tests need to provide the --command flag to kubectl run?

kubectl run NAME --image=image [--env="key=value"] [--port=port] [--dry-run=server|client] [--overrides=inline-json]
[--command] -- [COMMAND] [args...] [options]

https://github.com/cloudfoundry/cf-for-k8s/blob/c07f67382676420ed6b4204fe166c3cc01944e4b/ci/tasks/run-external-blobstore-validation-test/task.sh#L64

davewalter commented 3 years ago

@tcdowney We had a misconfiguration in our contributions pipeline for this job. It's green now. :)