search

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes
Apache License 2.0
300 stars 115 forks source link

Remove resource requirements also from istio init container #572

Closed kramerul closed 3 years ago

kramerul commented 3 years ago

WHAT is this change about?

If the config variable remove_resource_requirements is set to true, the resource requirements should also be removed from the istio init containers and also from StatefulSets and Jobs.

See also post in Slack

Does this PR introduce a change to config/values.yml?

No

Acceptance Steps

Tag your pair, your PM, and/or team

@loewenstein, @Haegi , @phil9909

Things to remember

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/175719352

The labels on this github issue will be updated when the story is started.

kramerul commented 3 years ago

I had a look at the test but was not able to see that the failure is related to the change. The flag remove_resource_requirements is not set to true for these tests.