Closed paulcwarren closed 3 years ago
We have created an issue in Pivotal Tracker to manage this:
https://www.pivotaltracker.com/story/show/175752287
The labels on this github issue will be updated when the story is started.
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:
WHAT is this change about?
Add Quarks Secrets behind an experimental feature flag to start driving server side secret generation. Along with the QuarksSecret controller, this PR migrates a few existing secrets to QuarksSecrets. Subsequently, we will update the remaining generated secrets and provide a migration path from user-provided data values to server side generated QuarksSecrets.
Also add ytt unit testing for the experimental feature flag. This PR depends on the addition of new matchers to the yttk8smatchers repo: https://github.com/cloudfoundry/yttk8smatchers/commit/d207637ab62efe1227d64ded4c685444dd8864a2 .
Does this PR introduce a change to
config/values.yml
?Yes, adds an experimental feature flag to the data values interface.
Acceptance Steps
kubectl get secret -n cf-system cf-admin-client-credentials -o yaml | yq -r .data | base64 --decode
Validate that when the experimental feature flag is enabled, we deploy QuarksSecret
After generating your values, go into the file and manually add the following config:
Continue to deploy normally with the feature flag enabled
Validate that we now have a QuarksSecret deployment with
kubectl get deployment -n cf-system cf-quarks-secret
Validate that we now have QuarksSecrets with server-side generated values with
kubectl get quarkssecrets -n cf-system
andkubectl get secret -n cf-system cf-admin-user-credentials -o yaml | yq -r '.data["password"]' | base64 --decode && echo
Smoke tests continue to pass normally
Tag your pair, your PM, and/or team
cc @cloudfoundry/cf-release-integration
Notes
#175423840 #173754832 #173799297