cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes
Apache License 2.0
300 stars 115 forks source link

Allow docker auth for smoke tests #581

Closed nhsieh closed 3 years ago

nhsieh commented 3 years ago

Thanks for contributing to cf-for-k8s!

We've designed this PR template to speed up the PR review and merge process - please use it.

WHAT is this change about?

This passes through environment variables to the smoke tests for dockerhub authentication. Related to https://github.com/cloudfoundry/cf-for-k8s/issues/580.

Does this PR introduce a change to config/values.yml?

No

Acceptance Steps

Please replace this with a series of instructions (eg kubectl or cf cli commands) for how our Product Manager can verify that your changes were properly integrated.

Tag your pair, your PM, and/or team

Optional but it's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

Things to remember

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/175858781

The labels on this github issue will be updated when the story is started.