Update getting-started-tutorial.md

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes

Apache License 2.0

300 stars 115 forks source link

Closed mshahat closed 3 years ago

mshahat commented 3 years ago

yq v4 has removed support for yq read command and is replaced by eval with some change in the syntax. The change is explained here https://mikefarah.gitbook.io/yq/upgrading-from-v3

Thanks for contributing to cf-for-k8s!

We've designed this PR template to speed up the PR review and merge process - please use it.

Update for the getting-started-tutorial.md to fix syntax change for yq that's breaking the authentication to cf api

No

Doc change

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

The labels on this github issue will be updated when the story is started.

linux-foundation-easycla[bot] commented 3 years ago

The committers are authorized under a signed CLA.

jamespollard8 commented 3 years ago

Good find and callout @mshahat - thanks for the PR!

I opted to remove yq entirely as a dependency for the getting started guide here: 89c24f4e

I also added comments to help clarify that we've aligned on using the python yq module for this project.

How does the commit I just made look to you? 89c24f4e

mshahat commented 3 years ago

thanks @jamespollard8 . I'm using the new approach already, thanks for that. /Mo

jamespollard8 commented 3 years ago

thanks @jamespollard8 . I'm using the new approach already, thanks for that. /Mo

Great - I'm glad to hear that 👍