search

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes
Apache License 2.0
300 stars 115 forks source link

PodDisruptionPolicy prevents Kubernetes upgrades #604

Closed braunsonm closed 3 years ago

braunsonm commented 3 years ago

Describe the bug

This bug was discussed on Slack here, I'm just making an issue so that it isn't forgotten. If its already been fixed then please close!

An Istio PodDisruptionPolicy prevents upgrades to K8S since cf-for-k8s deploys only a single replica of istiod. This means that the node running istiod cannot be drained which will fail the upgrade.

To Reproduce*

Steps to reproduce the behavior:

  1. Deploy cf-for-k8s 1.1
  2. Attempt a kubernetes upgrade
  3. Notice the node running istiod will never be drained

Expected behavior

cf-for-k8s should deploy 2 replicas of istiod by default and 1 when running without resource constraints (for laptop/development deployments)

Additional context

cf-for-k8s SHA

v1.1.0 tag

Cluster information

AKS

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176366929

The labels on this github issue will be updated when the story is started.

jamespollard8 commented 3 years ago

Thanks for the callout and great suggestion @braunsonm and @tcdowney. We fixed this in f63e71a9