MAINT: remove internal cert

jamespollard8 commented 3 years ago

We believe the internal cert is no longer necessary.

Next steps:

[x] configure "plaintext" (Istio handled) via overlays instead of editing "vendired" files

Thanks for contributing to cf-for-k8s!

We've designed this PR template to speed up the PR review and merge process - please use it.

WHAT is this change about?

Ripping out the internal certificate if it's no longer needed.

Yes. I'm not sure if removing a value is a breaking change.

1) PR tests pass 2) When I review the codebase, I see no more references to the internal certificate

Make sure this PR is based off the develop branch
Include any links to related PRs, issues, stories, slack discussions, etc... that will help establish context.
Is there anything else of note that the reviewers should know about this change?
Our CI uses concourse task files from HEAD of the develop branch. If your PR includes/requires CI changes, please ping the RelInt interrupt and they'll help apply the CI changes for you.
Checkout the contributing guidelines

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

The labels on this github issue will be updated when the story is started.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

Birdrock commented 3 years ago

@jamespollard8 Looks good to me. Squash/merge some of the commits to tidy up the history and I'd say it's ready.