MAINT: remove KinD patch to disable snapshot annos - Githubissues

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes

Apache License 2.0

301 stars 115 forks source link

MAINT: remove KinD patch to disable snapshot annos #629

Closed jamespollard8 closed 3 years ago

jamespollard8 commented 3 years ago

Kind should now be using a new enough version of containerd (v1.4.2+) such that this work-around isn't required
Related to #444

Acceptance Steps

PR tests pass, specifically the KinD tests

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177051225

The labels on this github issue will be updated when the story is started.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

jspawar commented 3 years ago

GKE-related checks failed, but only because we hadn't introduced our fix related to: #614

The Kind-related checks passed, so we're reasonably convinced this is good to merge and doing so as a result