Adopt restructuring of Eirini config maps

danail-branekov commented 3 years ago

WHAT is this change about?

In order to support different configurations in the CRD flow, Eirini configmaps have been split into two (one for the traditional REST API and one for the CRD flow). This PR adopts that change and sets the unsafe_allow_automount_service_account_token to true in both REST and CRD configurations on Kind.

NOTE: Please only merge this PR when bumping Eirini to the successor of the v3.0.0 release!

Related Eirini backlog item: https://www.pivotaltracker.com/story/show/176961023

Does this PR introduce a change to `config/values.yml`?

No

Acceptance Steps

Bump Eirini to the v3.0.0 successor (e.g. v3.0.1 when out, or develop if you are feeling lucky)
Deploy on Kind
See unsafe_allow_automount_service_account_token has been set to true in both api and controller configmaps

Tag your pair, your PM, and/or team

@cloudfoundry/eirini

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177115325

The labels on this github issue will be updated when the story is started.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

Birdrock commented 3 years ago

@danail-branekov Thanks for the PR! We'll wait until we see the next Eirini release. At that point, this PR will need some updates to resolve conflicts, but we'll cross that bridge when we come to it.

gcapizzi commented 3 years ago

Closing in favour of #643.

cloudfoundry / cf-for-k8s