search

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes
Apache License 2.0
301 stars 115 forks source link

Make quarks-secret image configurable with overlay #655

Closed Birdrock closed 3 years ago

Birdrock commented 3 years ago

#177585539

Co-authored-by: Andrew Costa ancosta@vmware.com

WHAT is this change about?

Make the images used by the quarks-secret templates configurable via data value driven ytt overlays.

Does this PR introduce a change to config/values.yml?

Yes. Adds values block for quarks-secret image.

Acceptance Criteria

Enable Quarks Secret with the experimental.quarks_secret.enabled configuration flag and otherwise deploy cf-for-k8s normally. Verify that smoke tests pass.

Tag your pair, your PM, and/or team

@acosta11 #177585539

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177703439

The labels on this github issue will be updated when the story is started.

cf-rel-int-status-bot commented 3 years ago

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! :eyes:

acosta11 commented 3 years ago

Manually verified Quarks Secret continues to work manually using the acceptance criteria listed as the CI checks do not actually enable quarks. Proceeding to merge.