search

cloudfoundry / cf-for-k8s

The open source deployment manifest for Cloud Foundry on Kubernetes
Apache License 2.0
300 stars 115 forks source link

ENH: Add an Istio version label to all system components #665

Closed davewalter closed 3 years ago

davewalter commented 3 years ago

WHAT is this change about?

This PR adds an Istio version label to all system components. This will cause kapp to roll the components whenever the Istio version changes, which will result in the new version of the proxy sidecar being injected into the pods.

#177914742

Does this PR introduce a change to config/values.yml?

No

Acceptance Steps

Deploy a previous version of cf-for-k8s that includes an old version of Istio, then upgrade to this version and confirm that all system component pods are rolled during the upgrade, and that kapp waits for them all to be ready again before proceeding.

Tag your pair, your PM, and/or team

@Birdrock

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/178030146

The labels on this github issue will be updated when the story is started.

acosta11 commented 3 years ago

We manually verified that everything rolled on an update from Istio 1.9.4 -> 1.9.5 as expected. LGTM

Thanks, Andrew and @tcdowney

Birdrock commented 3 years ago

fixes #663